Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update JSDoc in packages/astro/src/types/public/common.ts #12782

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

fhiromasa
Copy link
Contributor

@fhiromasa fhiromasa commented Dec 19, 2024

Changes

update JSDoc in packages/astro/src/types/public/common.ts

                next: string | undefined;
                /** url of the first page (if the current page is not the first page) */
                first: string | undefined;
-               /** url of the next page (if the current page in not the last page) */
+               /** url of the last page (if the current page is not the last page) */
                last: string | undefined;
        };
 }
  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

I don't think test is needed for this change.

Docs

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: a487652

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Dec 19, 2024
Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #12782 will not alter performance

Comparing fhiromasa:fix/comment (a487652) with main (f632b94)

Summary

✅ 4 untouched benchmarks

@fhiromasa fhiromasa changed the title update comment in packages/astro/src/types/public/common.ts update JSDoc in packages/astro/src/types/public/common.ts Dec 20, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ematipico ematipico merged commit f3d8385 into withastro:main Dec 20, 2024
17 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants