Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: netlify adapter site requirement #2996

Merged
merged 5 commits into from
Apr 5, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Human-readable error when "site" or invalid "base" are present
  • Update README to mention requirement

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022

🦋 Changeset detected

Latest commit: 67d92bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'd also support making Astro.canonicalURL a getter that throws when you attempt to use it having not provided a site. But we can document the current behavior, for now.

@matthewp matthewp merged commit 77aa3a5 into main Apr 5, 2022
This was referenced Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants