Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated Solid's client renderer and integration to fix issue with nested hydration, like you'd find in the recursive comments in Hackernews.
Previous behavior recreated static children as DOM elements and inserted them during hydration. This reset hydration state messing with Solid's hydration when nested.
Solid treats any
undefined
value inserted as skip during hydration assuming client will match server eventually, so I just removed the children and it will skip hydration of static children.This also appears to improve the Solid integration's hydration performance by about 200%.
Testing
Docs