Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): astro:build:done dir now matches SSR client output #3008

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

JuanM04
Copy link
Contributor

@JuanM04 JuanM04 commented Apr 6, 2022

Changes

In the case of the Vercel integration, the static files are outputted to .output/static/, whereas, for example, the Sitemap integration was saving its output inside .output/. This PR fixes that case

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022

🦋 Changeset detected

Latest commit: 6dcd136

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
astro Patch
@astrojs/partytown Patch
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 6, 2022
@matthewp
Copy link
Contributor

matthewp commented Apr 6, 2022

Sounds reasonable! I don't see the Sitemap integration being changed here though?

@JuanM04
Copy link
Contributor Author

JuanM04 commented Apr 6, 2022

@matthewp I didn't need any changes. The current code works as is!

@matthewp matthewp merged commit 8bd49c9 into main Apr 6, 2022
@github-actions github-actions bot mentioned this pull request Apr 6, 2022
@JuanM04 JuanM04 deleted the fix/build-done-dist branch April 6, 2022 23:20
This was referenced Apr 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
…ut (withastro#3008)

* `dir` now matches client output

* Updated integrations

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants