Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify outdirectory #3377

Merged
merged 4 commits into from
May 16, 2022
Merged

Netlify outdirectory #3377

merged 4 commits into from
May 16, 2022

Conversation

sarahetter
Copy link
Contributor

Changes

  • Changes the outDir to /dist/ - as /netlify/ is a directory that Netlify users add their own Edge Functions to, and we don't want to overwrite them when building.
  • Modifies the out directory for the entry.js file to ./.netlify/edge-functions as we do not want this file in the dist directory.

Testing

This change was tested against an astro project, set up with the @astro/netlify package. I have confirmed that it builds the site to the dist directory, and puts the relevant server file in ./.netlify/edge-functions

Docs

Updated documentation in package README.md

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

🦋 Changeset detected

Latest commit: 61c6144

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/netlify Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 16, 2022
@matthewp
Copy link
Contributor

Hi, thank you! Everything looks good here aside from the changesets piece. It looks like maybe you ran the changeset from inside the packages/astro subfolder. It should be run from the root folder. Would you mind:

  1. Deleting the packages/astro/.changeset subfolder that was created.
  2. Run pnpm run changeset from the root folder of the project and go through the prompts.

That should fix everything, thank you!

@sarahetter
Copy link
Contributor Author

Thanks @matthewp ! I've fixed the changeset

@matthewp matthewp merged commit e1294c4 into withastro:main May 16, 2022
@github-actions github-actions bot mentioned this pull request May 16, 2022
@sarahetter sarahetter deleted the netlify-outdirectory branch May 16, 2022 16:07
florian-s-code pushed a commit to florian-s-code/astro that referenced this pull request May 16, 2022
* Change dist directory, and functions out directory

* Add changeset

* update docs

* Fix changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants