Inline hydration directive scripts #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 86b1e85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
⚖️ Bundle Size CheckLatest commit: 86b1e85
|
|
I'm really excited for this, it'll boost perfs when using lots of components. |
natemoo-re
approved these changes
Jun 15, 2022
| @@ -2,6 +2,16 @@ | |||
| // Do not import this file directly, instead import the prebuilt one instead. | |||
| // pnpm --filter astro run prebuild | |||
|
|
|||
| type directiveAstroKeys = string; | |||
There was a problem hiding this comment.
Is this supposed to be the specific hydration method names rather than string?
There was a problem hiding this comment.
My thinking here was that we might support custom directives in the future and then this might actually be any string. But I didn't really think this all the way through so this might be too confusing as is, will change it.
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Inline hydration scripts * Adds a changeset * Update directiveAstroKeys type
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Inline hydration scripts * Adds a changeset * Update directiveAstroKeys type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Astro.load,Astro.idle, etc.Testing
Docs
N/A, perf optimization.