-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editor integrations to language integrations #3864
Conversation
🦋 Changeset detectedLatest commit: 66ab23b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Are you going to hard-code these packages with ./editor
files into the language server? Or would it make sense to add an editorEntrypoint
to the manifest in src/index.ts
?
I would've loved to! But it would require the manifest to also be CJS I think? I figured I'd limit my CJS-corruption to a single file 😓 |
Ah, I totally see what you mean @Princesseuh! Disregard. 👍🏻 |
Changes
Bit of a tentative PR. It moves the functions needed for the editor integration inside the integrations themselves instead of being in the language server. This will be followed by a PR in the language server to dynamically load that module
The reasoning for doing this is that it'll massively reduce the dependencies of the language server, which should make it much smaller (which is very desirable for
astro check
)Testing
I am not too sure how to test this here, the language server CI does test it however
Docs
N/A