Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration README fixes #3865

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Integration README fixes #3865

merged 4 commits into from
Jul 8, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Jul 8, 2022

Changes

Miscellaneous small fixes caught while building the new system for showing the integration READMEs on the docs site.

  • Remove a stray XML tag in the sitemap integration README. This stray tag crashes builds because micromark doesn’t expect tags to start with <?.

  • Fix some broken links caught by the docs link checker

These are fairly minor changes to READMEs, so I haven’t included a changeset, but can do if you think these fixes should trigger a patch release.

Testing

n/a

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: 688a507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@astrojs/deno Patch
@astrojs/image Patch
@astrojs/netlify Patch
@astrojs/node Patch
@astrojs/prefetch Patch
@astrojs/sitemap Patch
@astrojs/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 8, 2022
@delucis delucis changed the title Remove stray XML tag in sitemap integration README Integration README fixes Jul 8, 2022
@sarah11918
Copy link
Member

Changes LGTM.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks great, would definitely add a patch changeset to fix these!

@delucis delucis merged commit 1f9e485 into main Jul 8, 2022
@delucis delucis deleted the delucis/fix-readme branch July 8, 2022 19:56
@astrobot-houston astrobot-houston mentioned this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants