Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add errors to cloudflare/vercel adapters when no output config #4068

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add errors to cloudflare/vercel adapters when no output config #4068

merged 1 commit into from
Jul 27, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tests added for both.

Docs

None

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

🦋 Changeset detected

Latest commit: 45facff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/cloudflare Minor
@astrojs/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 27, 2022
tony-sull
tony-sull reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change and tests look good to me, just curious if it makes sense to override the config and avoid having to throw an error

@matthewp matthewp merged commit 54b33d5 into main Jul 27, 2022
@matthewp matthewp deleted the missing-output branch July 27, 2022 15:50
@astrobot-houston astrobot-houston mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-sull tony-sull tony-sull approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: @astrojs/vercel completely broken with new RC release
2 participants
@matthewp @tony-sull