Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cloudflare throwing over process #4072

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Fixes cloudflare throwing over process #4072

merged 4 commits into from
Jul 27, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Tests added, run wrangler dev which shows the same error.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

🦋 Changeset detected

Latest commit: 45b8640

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Patch
@astrojs/cloudflare Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jul 27, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Looks like there's a couple ESLint warnings for console logging that may be worth marking as eslint-disable-next-line just for the sake of keeping eslint happy

@matthewp matthewp merged commit a198028 into main Jul 27, 2022
@matthewp matthewp deleted the cloudflare-process branch July 27, 2022 20:15
@astrobot-houston astrobot-houston mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 1.0.0-rc.1 - Creating Node specific "proccess" in cloudflare _worker.js bundle
2 participants