-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Code component to run in Vercel #5409
Conversation
🦋 Changeset detectedLatest commit: ed4bcf2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview vercel-code |
|
!preview vercel-code |
|
!preview vercel-code |
|
!preview vercel-code |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable, but it is pretty unfortunate that this has the potential to blow up our bundle. Can't really think of a better option, though.
} | ||
code += '\n};'; | ||
|
||
console.log(code); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: fix lint warning
} | ||
code += '\n};'; | ||
|
||
console.log(code); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: fix lint warning
@natemoo-re I don't love it either. If it makes you feel better, these files were all being loaded anyways, they were just being loaded dynamically with Also this only affects sites that use Code, it's not pulled in with all Astro usage. |
That does make me feel better! Seems like the least bad option. LGTM! |
Changes
Testing
Docs
N/A, bug fix