Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all redirection status codes in redirect() #5446

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

jyasskin
Copy link
Contributor

Changes

This only changes the types file, not the implementation. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Status#redirection_messages for the list of redirection status codes.

Testing

Tested manually.

Docs

No docs; the restriction wasn't documented before.

@jyasskin jyasskin requested a review from a team as a code owner November 21, 2022 05:58
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2022

🦋 Changeset detected

Latest commit: 33775a2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 21, 2022
@sarah11918 sarah11918 removed the request for review from a team November 22, 2022 13:49
@jyasskin
Copy link
Contributor Author

jyasskin commented Dec 2, 2022

Sorry, did you want me to add 300 and 304, or to leave them out?

@bluwy bluwy merged commit 4f7f206 into withastro:main Dec 7, 2022
@astrobot-houston astrobot-houston mentioned this pull request Dec 7, 2022
@jyasskin
Copy link
Contributor Author

jyasskin commented Dec 7, 2022

Thanks!

@jyasskin jyasskin deleted the more-redirect-status-codes branch December 7, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants