Exclude astro from Vite optimization #5545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68b87d4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Astro package and subpaths shouldn't be prebundled as they are node-only, Astro components, types, or internal files.
Fixes #5517 but short-term only. The better approach which I can do soon is to have Vite's scanner recognize
---as searches imports there. That way we can set theoptimizeDeps.entriesassrc/pages/**/*and it should work properly.The issue with #5517 is that they put config subfiles in
srcand that makes Vite prebundle the scanned dependencies (which are almost always not used)Testing
Tested locally with the repro in #5517. Realistically someone shouldn't import
astroin their codebase but it could happen indirectly like in the issue.Docs
n/a bug fix