-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[markdown-remark] Remove unused dependencies #5804
Conversation
Follow up to #5785. Missed one dependency that is no longer used and can be removed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Looks like the lockfile needs another update before merging
Hmm, merging seems to have cause a lot more changes in the lockfile vs main. Maybe a bad merge? Yeah, looks like this is undoing lots of the most recent update lockfile CI. |
I tried removing the lock file and running |
Looking into the lockfile, it seems to be reverting the changes of the recent lockfile update. I usually do a merge, and during conflicts, run |
This was a good tip. Checked out I actually didn’t see any conflicts while merging, maybe because I have |
Yeah I never quite understood why |
Changes
Follow up to #5785. I missed that
acorn
andhast-util-to-html
are no longer used by@astrojs/markdown-remark
and can be removed as dependencies.Does this need a patch changeset separate to #5785 or is it minimal enough to ignore?
Testing
Existing tests should pass.
Docs
No docs needed.