Add support for serving well-known URIs with the @astrojs/node SSR adapter #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 709acec The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bluwy
approved these changes
Jan 11, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes #5813.
Well-Known locations, e.g.
/.well-known/apple-app-site-associationare properly served when runningastro devaltho this is not the case for a production build served using the@astrojs/nodeSSR adapter.This PR introduced changes discussed in #5813 and suggestions from @bluwy to properly serve well-known URIs (a URI whose path component begins with the characters
"/.well-known/"). This is achieved with 2 changes:publicdirectory, dotfiles are now also copied over.@astrojs/nodeadapter no longerdenydotfiles for well-known URIs.Testing
astrotest forstatic-buildto ensure dotfiles from thepublicdirectory are copied over during an SSR build.@astrojs/nodetests in awell-known-locationssuite to ensure well-known URIs are properly served while other dotfiles are not.Docs
I couldn't find any mention of the current behavior in the documentation so I'm not sure if any changes are needed.
/cc @withastro/maintainers-docs for feedback!