Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for existing .git directory (and skip if one is found). #5953

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

ZermattChris
Copy link
Contributor

Changes

  • Add a check to see if there is already a .git directory in the cwd and inform that creating a new Repository was skipped if found.

Testing

Afraid I don't yet know how to fork/install/run/test Astro on my own, so this code is untested. Making sure that the directory path is correct needs an eyeball still.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: 8f40ee1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Jan 24, 2023
@matthewp
Copy link
Contributor

Seems pretty reasonable to me, would you mind adding a changeset? pnpm changeset.

@ZermattChris
Copy link
Contributor Author

ZermattChris commented Jan 24, 2023

Seems pretty reasonable to me, would you mind adding a changeset? pnpm changeset.

I'd be happy to, but don't know what a changeset is or how to create one properly! Have never tried to contribute to a big project before :-\

I now know what a Changeset is, how to make one and how to update a Pull Request! Whoop. (now just need to figure out how to run and do dev/test work on my local machine, so I can actually test my changes before doing a Pull and wasting someone's valuable time)

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for implementing this!

@matthewp matthewp merged commit 5c64324 into withastro:main Jan 26, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jan 26, 2023
@ZermattChris
Copy link
Contributor Author

Looks great, thanks for implementing this!

Awesome! I know this is beyond minor, but made me feel great that I did a teensy thing to help this amazing project - motivates me to dig deeper, learn more, and maybe one day offer more than a tweak! Made my day 😎👍

@astrobot-houston astrobot-houston mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants