Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solidjs integration for vercel edge build (adopting same mechanics as cloudflare) #6085

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

AirBorne04
Copy link
Contributor

@AirBorne04 AirBorne04 commented Feb 1, 2023

Changes

Testing

With the example react and solid projects from the repo.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2023

🦋 Changeset detected

Latest commit: 2cc1b93

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AirBorne04 AirBorne04 requested a review from bholmesdev February 1, 2023 14:53
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 1, 2023
@AirBorne04 AirBorne04 added pkg: vercel Related to Vercel adapter (scope) and removed pkg: integration Related to any renderer integration (scope) labels Feb 1, 2023
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esbuilt for success!

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 1, 2023
@bholmesdev bholmesdev merged commit b236b5c into withastro:main Feb 1, 2023
@astrobot-houston astrobot-houston mentioned this pull request Feb 1, 2023
matthewp pushed a commit that referenced this pull request Feb 3, 2023
…cs as cloudflare) (#6085)

* fix solidjs integration for vercel deployment

* downgrade change to patch

---------

Co-authored-by: AirBorne04 <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: vercel Related to Vercel adapter (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SolidJS integration breaks app when used in Vercel Edge
3 participants