-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vercel analytics support #6148
Conversation
🦋 Changeset detectedLatest commit: ee6a7f7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tiny comments from docs, but otherwise the docs changes are approved!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
8f66dbc
to
30a89fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, amazing work! There are some little things to change before merging, but it's great
@JuanM04 Thx a lot for your awesome suggestions. I have changed them. But I don't know how to use changeset. It can only add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a great addition @jsun969! Left a couple more small comments.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Thanks @jsun969 for this valuable contribution. Will wait for another maintainer to approve as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
fotgot to mention: vercel analytics is a free service during the beta. We may need to modify this config if it needs to be paid later |
Changes
Add vercel analytics support for
@astrojs/vercel
withastro/roadmap#467
Testing
sry I didn't add tests. I assume it need to be tested in production. Also, I didn't find other tests for other props in
@astrojs/vercel
Docs
Added!
cc @natemoo-re @delucis