Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vercel analytics support #6148

Merged
merged 18 commits into from
Feb 8, 2023
Merged

Conversation

jsun969
Copy link
Contributor

@jsun969 jsun969 commented Feb 6, 2023

Changes

Add vercel analytics support for @astrojs/vercel

withastro/roadmap#467

Testing

sry I didn't add tests. I assume it need to be tested in production. Also, I didn't find other tests for other props in @astrojs/vercel

Docs

Added!

cc @natemoo-re @delucis

@jsun969 jsun969 requested a review from a team as a code owner February 6, 2023 11:58
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

🦋 Changeset detected

Latest commit: ee6a7f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 6, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny comments from docs, but otherwise the docs changes are approved!

packages/integrations/vercel/README.md Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
@jsun969 jsun969 force-pushed the feat/vercel-analytics branch from 8f66dbc to 30a89fa Compare February 7, 2023 05:04
@jsun969 jsun969 requested review from delucis and natemoo-re and removed request for delucis and natemoo-re February 7, 2023 05:04
Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, amazing work! There are some little things to change before merging, but it's great

packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
packages/integrations/vercel/package.json Outdated Show resolved Hide resolved
packages/integrations/vercel/src/serverless/adapter.ts Outdated Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
@jsun969
Copy link
Contributor Author

jsun969 commented Feb 8, 2023

@JuanM04 Thx a lot for your awesome suggestions. I have changed them. But I don't know how to use changeset. It can only add a major change for me and generate a .changeset/eighty-bobcats-deliver.md. I don't know if I did it right. Hope to get your help <3

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a great addition @jsun969! Left a couple more small comments.

.changeset/eighty-bobcats-deliver.md Outdated Show resolved Hide resolved
packages/integrations/vercel/src/analytics.ts Outdated Show resolved Hide resolved
packages/integrations/vercel/src/analytics.ts Outdated Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
jsun969 and others added 4 commits February 8, 2023 19:23
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@jsun969 jsun969 requested a review from delucis February 8, 2023 11:59
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks @jsun969 for this valuable contribution. Will wait for another maintainer to approve as well.

Copy link
Contributor

@JuanM04 JuanM04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@JuanM04 JuanM04 merged commit 23c60cf into withastro:main Feb 8, 2023
@astrobot-houston astrobot-houston mentioned this pull request Feb 8, 2023
@jsun969
Copy link
Contributor Author

jsun969 commented Feb 9, 2023

fotgot to mention: vercel analytics is a free service during the beta. We may need to modify this config if it needs to be paid later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants