Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head injection misplacement with Astro.slots.render() #6196

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 9, 2023

Changes

Testing

  • Tested for slots in slots (unaffected by this bug, but tested anyways).
  • Tested slots directly within Astro.slots.render()
  • Tested slots inside of slots inside of Astro.slots.render()
  • This should cover every possible way that Astro.slots.render() could mess up head injection.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2023

🦋 Changeset detected

Latest commit: 829e4d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 9, 2023
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 9, 2023
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Injust get this merged already

@matthewp matthewp merged commit 3390cb8 into main Feb 9, 2023
@matthewp matthewp deleted the css-in-body-again branch February 9, 2023 16:50
@astrobot-houston astrobot-houston mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
2 participants