Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency improvements to several package descriptions #6494

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

yanthomasdev
Copy link
Member

Changes

Changed several package descriptions so they all are following the same rules and display better in the astro.build site.

Testing

I hope changing a description doesn't break packages 😬

Docs

Docs, docs, and docs.
/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2023

🦋 Changeset detected

Latest commit: 673e448

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Mar 9, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks great!

@@ -1,6 +1,6 @@
{
"name": "@astrojs/alpinejs",
"description": "The official Alpine.js integration for Astro.",
"description": "Use Alpine within Astro",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Within" sounds a little formal here. Is there another word that's accurate enough and doesn't sound weird? "with" or "in"... 😆

Copy link
Member Author

@yanthomasdev yanthomasdev Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "with" is fine, I used "within" just to be consistent with the other UI framework integration packages, they all follow "Use (React) components within Astro". The "components" part doesn't apply to Alpine because it's more of additional methods and properties to use in HTML. So, if we change this, I'd also feel like changing the other UI frameworks to use "with" too, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yan-Thomas I am generally happier using "with" unless you really mean to emphasize inside. The place I mostly use "within" in docs is to say that something has to be located "within" src/pages/ (meaning, anywhere inside, including a subdirectory.) I could also see using it "within a component..." or "within your template..." again, meaning inside.

So if you want to update others to say "with" I think that's great! I also think if people are searching, they're more likely to type "How do I use Alpine with Astro" (or "and Astro") not "within."

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Yan! I do like the more active verb descriptions. Would be nice to maybe be able to get rid of that one "within" but non-blocking!

@natemoo-re natemoo-re merged commit a13e9d7 into main Mar 13, 2023
@natemoo-re natemoo-re deleted the yan/more-descriptions branch March 13, 2023 14:25
@astrobot-houston astrobot-houston mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants