Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Fix getImage type requesting for a second parameter #6961

Merged
merged 3 commits into from
May 2, 2023

Conversation

Princesseuh
Copy link
Member

Changes

getImage type was pointing to the internal function, which takes two parameters. But we expose a wrapper in our vite virtual module that does not require it, so we need a separate definition

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: 4513f64

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 2, 2023
@Princesseuh Princesseuh merged commit a695e44 into main May 2, 2023
@Princesseuh Princesseuh deleted the fix/get-image-types branch May 2, 2023 12:23
@astrobot-houston astrobot-houston mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants