Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Installs underneath a path containing leading underscores #7476

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

hirasso
Copy link
Contributor

@hirasso hirasso commented Jun 25, 2023

Fixes #7406

Makes it possible to run astro underneath a path that contains leading underscores, like e.g. /_my/path/to/site/.

Changes

  • Make the glob patterns in the astroContentVirtualModPlugin relative to the content directory

Testing

I really don't know how I should test this using a written test. Tested it manually instead.

Still, out of curiosity I ran pnpm run test. There were a few tests that were failing for me, regardless of the proposed change from this PR.

Docs

This is a bugfix, no docs needed I guess

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2023

🦋 Changeset detected

Latest commit: 2f3bf68

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 25, 2023
@hirasso hirasso changed the title Fix installs underneath a path with a folder with a leading underscore Fix installs underneath a path containing leading underscores Jun 25, 2023
@hirasso hirasso changed the title Fix installs underneath a path containing leading underscores fix: Installs underneath a path containing leading underscores Jun 25, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! The test should work fine, but maybe you're seeing flaky tests locally. I'm fine with not having tests for this for now though since it relies on an underscore outside the project filesystem.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@bluwy bluwy merged commit 478cd9d into withastro:main Jun 26, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 26, 2023
@hirasso hirasso deleted the fix/glob-with-underscores-ignored branch June 26, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectionDoesNotExistError on fresh install of "Astro Starter Kit: Blog"
2 participants