fix: correct URL for entry points #7490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3d2c10 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
fix/ssr-output-directory
branch
from
9c0a4ee to
74a8808
Compare
bluwy
approved these changes
Jun 27, 2023
Comment on lines
-114
to
-128
| export interface BuildConfig { | ||
| /** | ||
| * @deprecated Use config.build.client instead. | ||
| */ | ||
| client: URL; | ||
| /** | ||
| * @deprecated Use config.build.server instead. | ||
| */ | ||
| server: URL; | ||
| /** | ||
| * @deprecated Use config.build.serverEntry instead. | ||
| */ | ||
| serverEntry: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
Yeah it was long overdue
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There were two issues:
for..ininstead offor..of, because of that, the test was running but the for loop wasn't executed. Fixing that showed the issue and it was failing;entryPoints, which now uses the correctbuild.serverURLentryPointsin a changeset; we can't create a new changeset now because the feature is already released. I changedCHANGELOG.md. Once accepted, I will change the text of https://github.com/withastro/astro/releases/tag/astro%402.7.0Testing
Fixed the current test case
Docs
/cc @withastro/maintainers-docs for feedback!