Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vercel): Switch to node 18 when local version is not supported #7718

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Jul 19, 2023

Changes

Testing

What users will see when using an unsupported version

image

What users will see when using a deprecated version

image

Docs

  • Should not be required as this does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023

🦋 Changeset detected

Latest commit: 0ea087c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 19, 2023
@lilnasy lilnasy marked this pull request as ready for review July 19, 2023 15:17
@lilnasy lilnasy force-pushed the vercel-runtime-fix branch 2 times, most recently from 94d0074 to 41bc732 Compare July 19, 2023 19:24
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

packages/integrations/vercel/src/serverless/adapter.ts Outdated Show resolved Hide resolved
Comment on lines 23 to 24
14: { status: 'deprecated', removal: 'August 15th 2023' },
16: { status: 'deprecated', removal: 'February 6th 2024' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the US date format 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Intl.DateTimeFormat now 🫡

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant that mostly as a joke, but now it's even better! Thanks 🙌

Copy link
Contributor Author

@lilnasy lilnasy Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what it looks like

to french users

image

to north american users

image

to british/australian users

image

to egyptian users

image

@lilnasy lilnasy force-pushed the vercel-runtime-fix branch from 0ad2ccc to 8d3ae50 Compare July 20, 2023 14:24
@lilnasy lilnasy force-pushed the vercel-runtime-fix branch from 8d3ae50 to 78fe4f1 Compare July 20, 2023 14:30
@natemoo-re natemoo-re merged commit 35a0b6c into withastro:main Jul 20, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jul 20, 2023
@lilnasy lilnasy deleted the vercel-runtime-fix branch August 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants