Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unflag experimental.assets #7921

Merged
merged 8 commits into from
Aug 16, 2023
Merged

feat: unflag experimental.assets #7921

merged 8 commits into from
Aug 16, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Aug 2, 2023 •
edited
Loading

Changes

What the title says!

Testing

Updated tests and they should pass!

Docs

Sarah has a PR to docs in flight already for this!

@Princesseuh Princesseuh requested a review from a team as a code owner August 2, 2023 16:21
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 82c5185

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 2, 2023
@Princesseuh Princesseuh marked this pull request as draft August 2, 2023 17:22
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 14, 2023
@github-actions github-actions bot removed pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: create-astro Related to the `create-astro` package (scope) labels Aug 14, 2023
@Princesseuh Princesseuh marked this pull request as ready for review August 15, 2023 15:20
ematipico
ematipico approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

sarah11918
sarah11918 reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Princesseuh ! This is exciting.... :houston_intensifies:

Since it's just the changelog for the beta, we probably don't have to get too deep, but I thought that at least adding in that you have to uninstall the old integration, as well as a link to docs (since this is a pretty big change!) might be helpful here. So, something kind of like below I think does a good job of balancing enough warning about the breaking changes without overloading since it's just an experimental beta.

Feel free to use from this what you like!

.changeset/warm-weeks-yell.md Outdated Show resolved Hide resolved
@Princesseuh @sarah11918
Update .changeset/warm-weeks-yell.md
82c5185 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@Princesseuh Princesseuh merged commit b76c166 into next Aug 16, 2023
5 checks passed
@Princesseuh Princesseuh deleted the feat/unflagassets branch August 16, 2023 08:21
@astrobot-houston astrobot-houston mentioned this pull request Aug 16, 2023
Merged
fflaten
fflaten reviewed Aug 22, 2023
View reviewed changes
packages/astro/src/vite-plugin-inject-env-ts/index.ts
Comment on lines -63 to -68
typesEnvContents.includes('types="astro/client-image"')
) {
typesEnvContents = typesEnvContents.replace(
'types="astro/client-image"',
'types="astro/client"'
);
Copy link
Contributor

@fflaten fflaten Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Princesseuh Should this have stayed? Leaving projects at astro/client-image breaks import.meta.env type in non-astro files. Or only update 3.0 migration docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it should be mentioned in the 3.0 migration docs, but we probably should've kept this for convenience too... The right type to have in 3.0 is definitely astro/client, no matter what.

Copy link
Contributor

@fflaten fflaten Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not in migration guide yet. Not breaking builds, so might be enough to mentioned it there.
Wasn't obvious that I had to manually fix it before reading the removed TODO comment in this PR.

@Princesseuh Princesseuh mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOtterlord TheOtterlord TheOtterlord left review comments

@sarah11918 sarah11918 sarah11918 left review comments

@fflaten fflaten fflaten left review comments

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Princesseuh @matthewp @ematipico @fflaten @sarah11918 @TheOtterlord