Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StreamingCompatibleResponse polyfill #7981

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 7, 2023

Changes

Node 18 should support streaming (ReadableStream) through undici now, so we don't have to polyfill it.

Testing

Existing tests should pass.

Docs

n/a. internal change.

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: e51fc7c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 7, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Love that we're getting rid of this.

@natemoo-re
Copy link
Member

If we absolutely need to support native Node streams, we now have the option of using the native toWeb() method as well.

@bluwy bluwy merged commit c19adcd into next Aug 8, 2023
13 checks passed
@bluwy bluwy deleted the remove-streaming-response branch August 8, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants