-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: remove ~/assets alias #8113
Conversation
🦋 Changeset detectedLatest commit: c121733 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I just realized I did the exact same work as #7940 🤦♀️ |
Just a note that if there is going to be a changeset here, since there is a potentially user breaking change and you might want something to show up in the changelog, you can pull from the content here: https://deploy-preview-3739--astro-docs-2.netlify.app/en/guides/images/#remove-the-assets-import-alias But yes, advice for this will be covered in docs! |
Awww... and it was a first-time contributor! 😄 |
We talk often on Discord about |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Hey, wrote a whole bunch of code with @components, @layout, etc. In a 2.x build. |
Changes
What the title says, the alias didn't work properly in the editor because of how TypeScript works and it was a bit awkward to have now that
src/assets
isn't necessarily as special as it used to be. We'll revisit this in the future in a dedicated "should we have cool aliases?" RFC potentially. But for 3.0, no built-in aliases. Of course people can still define them themselves if they desire to.Testing
Kept the tests for aliases since it's good to test for people who configure them, but added the alias manually to those tests
Docs
Already covered by Sarah's current work on the v3 page for assets