Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace header with div #8204

Merged
merged 2 commits into from
Aug 23, 2023
Merged

refactor: replace header with div #8204

merged 2 commits into from
Aug 23, 2023

Conversation

dotarjun
Copy link
Contributor

Changes

This replaces header inside hero component to a div. Closes #8203

Testing

npm run dev

Docs

Docs not required

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9fa8676

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Aug 23, 2023
natemoo-re
natemoo-re approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and opening a PR!

@natemoo-re natemoo-re merged commit 85f2c24 into withastro:main Aug 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix accessibility issue in portfolio example
2 participants
@dotarjun @natemoo-re