Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unflag View Transition support #8218

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Unflag View Transition support #8218

merged 5 commits into from
Aug 25, 2023

Conversation

matthewp
Copy link
Contributor

Changes

  • Remove experimental.viewTransitions flag.
  • RFC was approved and merged

Testing

  • Tests updated to not have the flag.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 740ce03

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 24, 2023
@matthewp matthewp marked this pull request as ready for review August 24, 2023 19:08
@matthewp matthewp requested a review from a team as a code owner August 24, 2023 19:08
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Aug 24, 2023
github-actions[bot]
github-actions bot previously requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

ematipico
ematipico approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have the CLI flag to remove too?

@matthewp
Copy link
Contributor Author

matthewp commented Aug 25, 2023 •
edited
Loading

@ematipico No, I forgot to add one. It looks like we have forgotten to add the CLI flags for experimental features for the last few. We started documenting doing it view the Astro config so we'll have to revisit if we want to do the CLI flags in the future, or not.

sarah11918
sarah11918 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just shouting out that because of the API changes, they should also see the upgrading section in particular!

After that.... let's gooooo!

.changeset/grumpy-pens-melt.md Outdated Show resolved Hide resolved
@matthewp @sarah11918
Update .changeset/grumpy-pens-melt.md
8fec88a 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
github-actions[bot]
github-actions bot previously requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

github-actions[bot]
github-actions bot previously requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp merged commit 44f7a28 into main Aug 25, 2023
14 checks passed
@matthewp matthewp deleted the vt-unflagged branch August 25, 2023 15:20
@astrobot-houston astrobot-houston mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@ematipico ematipico ematipico approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewp @ematipico @sarah11918 @bluwy