fix(redirects): attempt to get only params in dev mode #8647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3748cbf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
lilnasy
commented
Sep 24, 2023
Comment on lines
+203
to
206
| it.skip('falls back to spread rule when dynamic rules should not match', async () => { | ||
| const response = await fixture.fetch('/more/old/welcome/world', { redirect: 'manual' }); | ||
| expect(response.headers.get('Location')).to.equal('/more/new/welcome/world'); | ||
| }); |
There was a problem hiding this comment.
I'll let someone else tackle this.
Merged
|
Hi, i am still using Astro 2.10 and I'm not ready to upgrade to Astro 3. Can you release this fix also for all affected 2.x versions? |
|
We don't have a system setup for that case. This is a small change, however. I'd recommend publishing an npm package for yourself with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
redirectserror #8639Testing
Adapted from repro.
Docs
Does not affect usage.