Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemarkRehype types #9147

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix RemarkRehype types #9147

merged 1 commit into from
Nov 22, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 21, 2023

Changes

Supersedes and closes #6211

The linked PR above explains why the types is incorrect today. This PR merges into next which includes the latest versions of the remark/rehype plugins, which I think should work now.

Testing

Existing test should pass. Also tested the types in an Astro config manually.

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 02f9d84

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pr: docs A PR that includes documentation for review labels Nov 21, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finally tackling this! ♥️

@bluwy bluwy merged commit addb57c into next Nov 22, 2023
13 checks passed
@bluwy bluwy deleted the fix-remark-rehype-types branch November 22, 2023 03:17
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants