Implement new a11y audits for the Dev Toolbar app #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 27d0388 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Base automatically changed from
feat/dev-overlay-main-screen-redesign
to
next
November 28, 2023 14:39
Princesseuh
force-pushed
the
feat/dev-overlay-audits
branch
from
aa628c6 to
45290ab
Compare
⚖️ Bundle Size CheckLatest commit: 27d0388
|
natemoo-re
force-pushed
the
feat/dev-overlay-audits
branch
from
68a9b07 to
4892c28
Compare
sarah11918
reviewed
Dec 1, 2023
There was a problem hiding this comment.
You weren't kidding about doing my work for me, @Princesseuh -- I took a peek before you went through these, and they are phenomenal now!
Just some tiny thoughts, and I thought you mentioned looking even at the todo ones, but they do still seem in TODO form, so I started pointing things out, then just mentioned when I thought they would need some attention
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
natemoo-re
force-pushed
the
feat/dev-overlay-audits
branch
from
23b368b to
39bf864
Compare
…1y.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
…1y.ts Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
natemoo-re
changed the title
dummdidumm
reviewed
Dec 4, 2023
|
|
||
| The audits Astro performs are non-exhaustive and only intended to catch a handful of common accessibility issues. Please take care to perform a thorough accessibility audit before releasing your website. | ||
|
|
||
| 🧡 Huge thanks to the [Svelte](https://github.com/sveltejs/svelte) team for providing the basis of these accessibility audits! |
bluwy
reviewed
Dec 4, 2023
packages/astro/src/runtime/client/dev-overlay/plugins/audit/a11y.ts
Outdated
Show resolved
Hide resolved
natemoo-re
commented
Dec 4, 2023
matthewp
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
a11y.jsfile. This code is licensed under the MIT License per Svelte's LICENSE. Astro's LICENSE has been updated to reflect this.Testing
Tested manually for now
Docs
It would be great to have our own reference for all of these audits, but Svelte's Accessibility Warnings reference is a good stand-in for now.