Remove support for simple objects in endpoints #9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a6ec4d8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
bluwy
commented
Nov 23, 2023
Comment on lines
-3
to
+5
| export async function GET({ params, request }) { | ||
| const buffer = readFileSync(new URL('../../astro.png', import.meta.url)); | ||
| return { | ||
| body: buffer.toString('hex'), | ||
| encoding: 'hex', | ||
| }; | ||
| export async function GET() { | ||
| const buffer = await readFile(new URL('../../astro.png', import.meta.url)); | ||
| return new Response(buffer.buffer); |
There was a problem hiding this comment.
TIL readFile with promises return a correctly encoded buffer compared to the sync version. I'm not sure why.
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
MoustaphaDev
approved these changes
Nov 24, 2023
|
Thanks for the approval. Since this change is slightly big and probably worth a docs pass, I'll hold off merging for now. |
This was referenced Nov 27, 2023
matthewp
approved these changes
Nov 27, 2023
|
Yeah I found out over time that it's mostly to help simplify migration, most usecases can convert to |
sarah11918
approved these changes
Nov 27, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Also removes
ResponseWithEncodingand renames types for middlewares.A good chunk of the changes involved updating tests to not use the deprecated form.
Testing
Existing tests should pass.
Docs
Added to migration tracker