Fix i18n routing param #9274
Merged
Fix i18n routing param #9274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1dc0216 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
lilnasy
reviewed
Dec 3, 2023
There was a problem hiding this comment.
and we didnt get type errors here because it is a virtual module?
There was a problem hiding this comment.
Yeah, the call made in the virtual module would error if it was analysed by TS afaik
ematipico
approved these changes
Dec 4, 2023
Merged
akshit20421
added a commit
to akshit20421/astro
that referenced
this pull request
Dec 4, 2023
Fix i18n routing param (withastro#9274)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes usage of
routingas a param to match the newer config.TLDR:
getRelativeLocaleUrlListwas flagged as not returning/en/when the routing strategy wasprefix-always. Looks like that originated fromi18n/index.tsstill usingroutingStrategyfrom before the config was updatedTesting
Updated existing tests to match the new behaviour
Docs
N/A