Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove audit role that depends on CJS package #9293

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 4, 2023

Changes

  • The package axobject-query is CJS and Vite doesn't ESM-ify it, can't add to optimizedDeps.include.
  • Maybe there's something we can do to shim but removing for 4.0 release.

Testing

  • N/A

Docs

N/A

Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: 5a3a136

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 4, 2023
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Dec 4, 2023
@matthewp
Copy link
Contributor Author

matthewp commented Dec 4, 2023

The failing script is because it's tries to compare bundle size but installing the old version with the current deps.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix

@matthewp matthewp merged commit cf5fa43 into main Dec 4, 2023
13 of 14 checks passed
@matthewp matthewp deleted the remove-cjs-audit branch December 4, 2023 20:16
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants