Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set github action timeout to 3min / job #677

Merged
merged 3 commits into from
Dec 20, 2022
Merged

chore: set github action timeout to 3min / job #677

merged 3 commits into from
Dec 20, 2022

Conversation

jasikpark
Copy link
Contributor

Changes

  • All jobs consistently complete in under 3min - this should bring the generous default down to something that we can detect. CI sorta PR!

Testing

Docs

@jasikpark
Set github action timeout to 3min / job
d2af2e1 
All jobs consistently complete in under 3min - this should bring the generous default down to something that we can detect
@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: c10db4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jasikpark
Set a 30s per-test timeout for golang tests
621a797 
No test currently hits this timeout, should show slow tests
@jasikpark
Set test-wasm timeout to 10m
c10db4b
natemoo-re
natemoo-re approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jasikpark jasikpark merged commit 744b30b into main Dec 20, 2022
@jasikpark jasikpark deleted the add-timeout-to-workflows branch December 20, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasikpark @natemoo-re