Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JS Sourcemaps II #680

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Improve JS Sourcemaps II #680

merged 3 commits into from
Jan 4, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Dec 20, 2022

This reverts commit fd5cb57.

Changes

Testing

Need to add the failing condition

Docs

N/A

This reverts commit fd5cb57.
@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2022

🦋 Changeset detected

Latest commit: ca1806c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jasikpark
Copy link
Contributor

what changed?

@natemoo-re
Copy link
Member Author

Nothing yet! There was a failure here that I need to add a test case for https://github.com/withastro/astro/actions/runs/3744703887/jobs/6358389988

@natemoo-re natemoo-re changed the title JS Sourcemaps Take 2 Improve JS Sourcemaps II Jan 3, 2023
Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me, this is just a remerge + checking in a failing integration test w/ astro

would really be great to set up astro-compiler-remote-ci to test compiler changes against astro proper

@jasikpark
Copy link
Contributor

#341 👀 finally close this?

@natemoo-re natemoo-re self-assigned this Jan 3, 2023
@natemoo-re
Copy link
Member Author

!preview sourcemap

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--sourcemap" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--sourcemap tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-sourcemap-20230103195910) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-sourcemap-20230103195910" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-sourcemap-20230103195910 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-sourcemap-20230103195910

@natemoo-re
Copy link
Member Author

Preview is passing on main here withastro/astro#5656

@natemoo-re natemoo-re merged commit fcab891 into main Jan 4, 2023
@natemoo-re natemoo-re deleted the improve-js-sourcemaps-ii branch January 4, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Sourcemaps seem off
2 participants