Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mention that the user can change the placement of the dev toolbar #7720

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat: mention that the user can change the placement of the dev toolbar #7720

merged 3 commits into from
Apr 10, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Apr 1, 2024 •
edited
Loading

Description

  • Mentions that the user can change the placement of the dev toolbar
  • Updates related content

For Astro version: 4.6. See astro PR #10591.

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 10, 2024 9:44pm

@mingjunlu mingjunlu mentioned this pull request Apr 1, 2024
Merged
sarah11918
sarah11918 reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this @mingjunlu! I know it's still set as a draft, but just wanted to provide a quick suggestion here to see what you think!

src/content/docs/en/guides/dev-toolbar.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/dev-toolbar.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Apr 3, 2024
@mingjunlu @sarah11918
Apply suggestions from review
8a96606 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@mingjunlu mingjunlu marked this pull request as ready for review April 4, 2024 08:56
sarah11918
sarah11918 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you! I'll keep an eye out to merge this when 10591 is!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 4, 2024
@sarah11918 sarah11918 added this to the 4.6.0 milestone Apr 4, 2024
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Apr 8, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.6.0 April 10, 2024 21:34
@sarah11918 sarah11918 merged commit 2c4ae4a into withastro:4.6.0 Apr 10, 2024
2 of 3 checks passed
@sarah11918 sarah11918 mentioned this pull request Apr 10, 2024
Merged
@mingjunlu mingjunlu deleted the feature/dev-toolbar-placement branch April 11, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mingjunlu @sarah11918