Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update biome #818

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chore: update biome #818

merged 1 commit into from
Mar 11, 2024

Conversation

ematipico
Copy link
Member

Changes

  • Updated biome to the latest.
  • biome now formats package.json files. Happy to revert the changes. They are different from prettier because prettier just format them with JSON.strigify(content, null, 2).
  • I removed the eslint prettier packages because they aren't needed anymore.
  • Biome now handles Astro and Svelte files, with some limitations. For example the indentation in the svelte file is different (and expected). Happy to revert it if not wanted.

Testing

The CI should still pass

Docs

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: 89a41fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Princesseuh
Copy link
Member

Princesseuh commented Mar 8, 2024

I would prefer if we ignore fixtures, because some of the tests depend on precise positions that formatting could prevent from working (probably should've been ignored in Prettier too)

@ematipico
Copy link
Member Author

@Princesseuh done!

@Princesseuh Princesseuh merged commit ba47241 into main Mar 11, 2024
4 checks passed
@Princesseuh Princesseuh deleted the chore/update-biome branch March 11, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants