Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Remove use of Google+ APIs #4518

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Remove use of Google+ APIs #4518

merged 1 commit into from
Jan 7, 2019

Conversation

brianlovin
Copy link
Contributor

@brianlovin brianlovin commented Jan 2, 2019

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • api

Google is deprecating the Google+ APIs in March, but said that we should expect degradations in service starting in January. I was worried this would be a more involved migration process from Google+ auth to the generic "Google Sign-in" product - turns out, it just requires a change in scopes! Tested locally for creating a new user with Google signin and authenticating with an existing user via Google.

@ovflowd
Copy link

ovflowd commented Jan 2, 2019

Yeah Google+ APIs are being deprecated but only some of the scopes actually will be removed, the whole endpoints and Google Developer Console thing will remain the same 😄

@brianlovin
Copy link
Contributor Author

@ovflowd true! We are using scopes that are being deprecated though, specifically the plus.profile scope :)

@ovflowd
Copy link

ovflowd commented Jan 2, 2019

Cool! So that's easy to workaround. ✨

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio!

@mxstbr mxstbr merged commit 02eae94 into alpha Jan 7, 2019
@mxstbr mxstbr deleted the update-google-signin-api branch January 7, 2019 08:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants