migrate to node 8 (fix cyclic dependencies bug)

wix-incubator · Dec 3, 2017 · c6554dc · c6554dc
1 parent 96e00cc
commit c6554dc
Show file tree

Hide file tree

Showing 4 changed files with 1,823 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,3 +1,3 @@
 language: node_js
 node_js:
-  - '0.10'
+  - '8'
diff --git a/index.js b/index.js
@@ -45,10 +45,11 @@ module.exports = function generateRequireForUserCode (scopedDirs, options) {
 
   function deleteModuleFromCache (m) {
     delete Module._cache[m.id]
-    _.forEach(m.children, function (subModule) {
+    const moduleChildren = m.children
+    m.children = []
+    _.forEach(moduleChildren, function (subModule) {
       deleteModuleFromCache(subModule)
     })
-    m.children = []
   }
 
   return {