fix: enables recording videos on iOS

detox/src/artifacts/ArtifactsManager.js

@@ -24,7 +24,6 @@ class ArtifactsManager {
   }
 
   async onStart() {
-    await fs.ensureDir(this.artifactsRootDir);
     await Promise.all(this.hooks.map(hook => hook.onStart()));
   }
 

detox/src/artifacts/index.js

@@ -73,7 +73,7 @@ const resolve = {
       })),
       ios: _.once((api) => new AppleSimUtilsVideoRecorder({
         appleSimUtils: resolve.appleSimUtils(api),
-        deviceId: api.getDeviceId(),
+        udid: api.getDeviceId(),
       })),
       actual: _.once(resolveByDeviceClass({
         'ios.none': (api) => resolve.artifacts.videoRecorder.none(api),

detox/src/artifacts/screenshotters/AppleSimUtilsScreenshotHandle.js

@@ -3,12 +3,16 @@ const fs = require('fs-extra');
 class AppleSimUtilsScreenshotHandle {
   constructor(config) {
     this.artifactPath = config.artifactPath;
+    this.temporaryFilePath = config.temporaryFilePath;
   }
 
-  async save() {}
+  async save() {
+    await fs.ensureFile(this.artifactPath);
+    await fs.move(this.temporaryFilePath, this.artifactPath, { overwrite: true });
+  }
 
   async discard() {
-    await fs.remove(this.artifactPath);
+    await fs.remove(this.temporaryFilePath);
   }
 }
 

detox/src/artifacts/screenshotters/AppleSimUtilsScreenshotter.js

@@ -1,20 +1,23 @@
 const fs = require('fs-extra');
+const tempfile = require('tempfile');
 const ensureExtension = require('../utils/ensureExtension');
 const AppleSimUtilsScreenshotHandle = require('./AppleSimUtilsScreenshotHandle');
 
 class AppleSimUtilsScreenshotter {
   constructor(config) {
     this.appleSimUtils = config.appleSimUtils;
+    this.temporaryFilePath = config.temporaryFilePath;
     this.udid = config.udid;
   }
 
   async takeScreenshot(artifactPath) {
-    const pngArtifactPath = ensureExtension(artifactPath, '.png');
-    await fs.ensureFile(pngArtifactPath);
-    await this.appleSimUtils.takeScreenshot(this.udid, pngArtifactPath);
+    const temporaryPngPath = tempfile('.png');
+    await fs.ensureFile(temporaryPngPath);
+    await this.appleSimUtils.takeScreenshot(this.udid, temporaryPngPath);
 
     return new AppleSimUtilsScreenshotHandle({
-      artifactPath: pngArtifactPath,
+      temporaryFilePath: temporaryPngPath,
+      artifactPath: ensureExtension(artifactPath, '.png'),
     });
   }
 }

detox/src/artifacts/videoRecorders/AppleSimUtilsVideoRecorder.js

@@ -1,3 +1,4 @@
+const tempfile = require('tempfile');
 const ensureExtension = require('../utils/ensureExtension');
 const IosVideoRecording = require('./AppleSimUtilsVideoRecording');
 
@@ -10,8 +11,9 @@ class AppleSimUtilsVideoRecorder {
   recordVideo(artifactPath) {
     return new IosVideoRecording({
       appleSimUtils: this.appleSimUtils,
-      artifactPath: ensureExtension(artifactPath, '.mp4'),
       udid: this.udid,
+      artifactPath: ensureExtension(artifactPath, '.mp4'),
+      temporaryFilePath: tempfile('.mp4'),
     });
   }
 }

detox/src/artifacts/videoRecorders/AppleSimUtilsVideoRecording.js

@@ -1,29 +1,52 @@
 const fs = require('fs-extra');
+const sleep = require('../../utils/sleep');
 
 class AppleSimUtilsVideoRecording {
   constructor(config) {
     this.appleSimUtils = config.appleSimUtils;
     this.artifactPath = config.artifactPath;
+    this.temporaryFilePath = config.temporaryFilePath;
     this.udid = config.udid;
     this.processPromise = null;
     this.process = null;
   }
 
   async start() {
-    await fs.ensureFile(mp4ArtifactPath);
-    this.processPromise = this.appleSimUtils.recordVideo(this.udid, this.artifactPath);
+    await fs.ensureFile(this.temporaryFilePath);
+    this.processPromise = this.appleSimUtils.recordVideo(this.udid, this.temporaryFilePath);
     this.process = this.processPromise.childProcess;
+
+    await this._avoidAbruptVideoBeginning();
   }
 
   async stop() {
+    if (!this.process) {
+      return;
+    }
+
+    await this._avoidAbruptVideoEnding();
+
     this.process.kill('SIGINT');
     await this.processPromise;
   }
 
-  async save() {}
+  async _avoidAbruptVideoBeginning() {
+    await sleep(500);
+  }
+
+  async _avoidAbruptVideoEnding() {
+    await sleep(500);
+  }
+
+  async save() {
+    await fs.ensureFile(this.artifactPath);
+    await fs.move(this.temporaryFilePath, this.artifactPath, {
+      overwrite: true
+    });
+  }
 
   async discard() {
-    await fs.remove(this.artifactPath);
+    await fs.remove(this.temporaryFilePath);
   }
 }
 

detox/test/package.json

@@ -6,8 +6,8 @@
     "test": ":",
     "packager": "react-native start",
     "detox-server": "detox run-server",
-    "e2e:ios": "detox test --configuration ios.sim.release --debug-synchronization 10000",
-    "e2e:android": "detox test --configuration android.emu.release --loglevel verbose --record-videos failing",
+    "e2e:ios": "detox test --configuration ios.sim.release --debug-synchronization 10000 --take-screenshots failing --record-videos failing --record-logs failing",
+    "e2e:android": "detox test --configuration android.emu.release --take-screenshots failing --record-videos failing --record-logs failing",
     "build:ios": "detox build --configuration ios.sim.release",
     "build:android": "detox build --configuration android.emu.release"
   },