Skip to content

Commit

Permalink
fix eslint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@DanielMSchmidt
DanielMSchmidt committed Jun 1, 2018
1 parent ff6732b commit a6db945
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions detox/src/devices/IosDriver.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ const fs = require('fs');
const DeviceDriverBase = require('./DeviceDriverBase');
const InvocationManager = require('../invoke').InvocationManager;
const invoke = require('../invoke');
const GREYConfigurationApi = require('./../ios/earlgreyapi/GREYConfiguration');
const GREYConfigurationDetox = require('./../ios/earlgreyapi/GREYConfigurationDetox');
const EarlyGrey = require('./../ios/earlgreyapi/EarlGrey');
const GREYConfigurationApi = require('./../ios/earlgreyapi/GREYConfiguration'); // eslint-disable-line node/no-unpublished-require
const GREYConfigurationDetox = require('./../ios/earlgreyapi/GREYConfigurationDetox'); // eslint-disable-line node/no-unpublished-require
const EarlyGrey = require('./../ios/earlgreyapi/EarlGrey'); // eslint-disable-line node/no-unpublished-require

class IosDriver extends DeviceDriverBase {
constructor(client) {
Expand Down
2 changes: 1 addition & 1 deletion detox/src/exportWrapper.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const platform = require('./platform');
const iosExports = require('./ios/expect');
const iosExports = require('./ios/expect'); // eslint-disable-line node/no-unpublished-require
const androidExports = require('./android/expect');

const exportMap = {
Expand Down

8 comments on commit a6db945

@rotemmiz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does eslint thinks it's an unpulished require?

@DanielMSchmidt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder the same 🤔

@rotemmiz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to understand why, it makes no sense

@DanielMSchmidt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will dig into this 👍

@noomorph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because ios/ folder is in .npmignore.

@noomorph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wix/detox/blob/master/detox/.npmignore#L9

@DanielMSchmidt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaaah, thank you for your help 👍 @rotemmiz Do you know the reason why ios/ is in the npmignore?

@noomorph
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielMSchmidt it is somehow autogenerated if I understand right and it has some relation to Detox-ios-src.tbz archive in the folder which probably is unpacked in post-install. My grasp might be inaccurate but, generally speaking, we have a sophisticated deployment there. @rotemmiz might know better.

Please sign in to comment.