-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detox incompatibility with Firebase SDK #270
Comments
Any idea? |
@mhyousefi what version of detox and RN firebase are you using? We are experiencing similar issues #267. |
I'm using: @SMJ93 Have you found any solutions yet? This issue is becoming a real stumbling block in my work.... |
@mhyousefi detox started from version 5. |
My bad! I corrected the version... |
@mhyousefi no sorry, we have put testing on hold. It's a shame because detox worked so well when spiking it a few months ago! |
I have a similar issue. The build is successful, but when doing detox test - the app launches for a second and closes. I see that the packager is trying to server the index.ios.js, but by the time it is ready, then the app is not working. I can launch the app manually and navigate around - it seems to work properly. This is my config:
and here is the log:
"react-native": "0.47.2", The project builds & runs fine with xcode or with react-native run-ios. |
There seems to be some kind of incompatibility with Firebase' own delegate proxy. @mhyousefi @compojoom Please provide information on how you have integrated Firebase in your app, so I can test in the same conditions. |
Also please share your configuration in the info.plist. |
that here is the guide: https://invertase.io/react-native-firebase/#/v2/installation-ios |
Thanks |
Yes, it needs to be generated in the firebase console. |
Please provide your own with the personal bits removed. |
@LeoNatan - if it would make things easier to replicate I can invite your to our private repository where the issues occurs. |
Is it a native or RN project? If native, please invite me. If not, I will create a small project and try to replicate the issue on my own. BTW, anyone of you guys using Swift? |
It's a RN project. |
OK, thanks. |
I think I found the issue, or at least an issue that could solve this. Will push a fix for this in a few. |
@LeoNatan how do I test your fix? I tried by specifiying the commit in my package.json, but this didn't work. Do I have to build the whole detox library somehow? |
The change is in the source control. An npm package needs to be released for you to test. @rotemmiz |
@rotemmiz - can we get a new version please. Or someone please explain how to generate a package from the repository? I didn't fully understand the contributing guide. If I want to build the package myself and run
Which files should I copy afterwards to my project? |
5.7.0 is out. please try it and report back. |
Unfortunately 5.7.0 is not fixing the issue for me.
|
I will continue investigating soon once our holidays are over. |
I'm seeing the same issues when using react-native versions 0.48.2 and 0.48.3. Downgrading to react-native 0.48.1 works for me |
Any progress on this? |
I'm having a similar issue:
I've added FirebaseAppDelegateProxyEnabled to my Info.plist, clean and then the problem disappeared. This is my config: {
"scripts": {
"test": "jest --setupTestFrameworkScriptFile=./src/utils/tests/setup.js --testMatch '**/?(*.)(test).js?(x)'",
"test:e2e": "jest e2e --setupTestFrameworkScriptFile=./src/utils/tests/e2e.js --runInBand"
},
"dependencies": {
"react": "16.0.0-alpha.12",
"react-native": "0.48.4"
},
"devDependencies": {
"detox": "^5.8.1",
"jest": "^21.2.1",
"react-dom": "^16.0.0",
"react-test-renderer": "16.0.0",
"redux-mock-store": "^1.3.0"
},
"jest": {
"preset": "react-native",
"bail": true,
"verbose": true
},
"detox": {
"configurations": {
"ios.sim.debug": {
"binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/Turismocity.app",
"build": "xcodebuild -workspace ios/Turismocity.xcworkspace -scheme Turismocity -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build",
"type": "ios.simulator",
"name": "iPhone 7"
}
}
}
} |
@maggialejandro your issue is discussed here |
@Kureev Up for some debugging as well? 😆 |
Would really appreciate it as setting up this Firebase environment is not very easy to setup. |
I had a same issue
At first I thought It is because of RN version, but it seems like Firebase is the issue. Would like to follow up this issue. Thanks. |
I’ll look at this issue today. Hopefully, I can solve it. |
Fixed. Will be integrated in the next version. |
Thanks @LeoNatan, is there a planned release date for the next version? |
Soon™ CC @rotemmiz |
@LeoNatan - is the fix in 5.8.4? Because I just tested it and my app keeps crashing.
|
That crash is unrelated to this issue. Please post in #279 along with the RN version you are using. |
Oh, sorry. |
When I run
detox test
, my app is installed and launched but immediately exits, moving to the home screen. The bundling process then starts and if I open up the app, it does work fine, but the tests are not run.THIS PROBLEM DOES NOT HAPPEN WITH
react-native run-ios
I have the basic detox configuration as bellow:
The stdout and stderr logs have the following content:
The error says to
Add "FirebaseAppDelegateProxyEnabled" to your Info.plist and set it to NO
and I did so, but the problem persistsI'm using
react-native 0.44.0
node v7.8.0
The text was updated successfully, but these errors were encountered: