Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IOS Driver to generated code #719

Closed
DanielMSchmidt opened this issue May 8, 2018 · 0 comments
Closed

Move IOS Driver to generated code #719

DanielMSchmidt opened this issue May 8, 2018 · 0 comments
Assignees
@DanielMSchmidt
Labels
domain: internal

Comments

@DanielMSchmidt
Copy link
Contributor

DanielMSchmidt commented May 8, 2018 •
edited
Loading

As a step in the direction of purely relying on generated code for the native adapters, we need to move the iOS Driver file detox/src/devices/IosDriver.js to use generated code. It still uses not generated code to trigger the device rotation.
@DanielMSchmidt DanielMSchmidt self-assigned this May 12, 2018
DanielMSchmidt pushed a commit that referenced this issue May 12, 2018
move device rotation to generated code
dd0fdb4 
Closes #719
@DanielMSchmidt DanielMSchmidt mentioned this issue May 12, 2018
Merged
DanielMSchmidt pushed a commit that referenced this issue May 16, 2018
@DanielMSchmidt
move device rotation to generated code
7210b3f 
Closes #719
DanielMSchmidt pushed a commit that referenced this issue May 21, 2018
move device rotation to generated code
f030712 
Closes #719
DanielMSchmidt pushed a commit that referenced this issue May 26, 2018
move device rotation to generated code
d52fd53 
Closes #719
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanielMSchmidt DanielMSchmidt

Labels
domain: internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DanielMSchmidt