-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android support. Phase I. #148
Conversation
This is an amazing step towards an Android version! |
Hey Rotem, The new commit contains the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few notes here for future use
compile "com.android.support:appcompat-v7:23.0.1" | ||
compile "com.facebook.react:react-native:+" // From node_modules | ||
|
||
testCompile 'junit:junit:4.12' | ||
androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to androidTestCompile
espresso here? I think we should just androidTestCompile
detox instead, and remove line 129.
import com.wix.detox.espresso.ReactBridgeIdlingResource; | ||
import com.wix.detox.espresso.ReactNativeTimersIdlingResource; | ||
|
||
import org.joor.Reflect; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may be able to use the same reflection library as we use for our internal reflection mechanism (a small wrapper on top of Apache ReflectionUtils)
Android support Phase I. (#96)
I tried to limit the scope to make a small PR. I failed in that. :)
Goals/achievements of this PR:
-- JS timers
-- JS bridge
-- UI thread
-- UI BG thread
-- Native Modules thread
-- JS thread
Non-goals of the PR:
I tested it manually in the following sample project detox-android-tester. I set up a websocket server and called hard-wired commands through it to the test runner.
I suggest to start at Detox.Java when checking this PR.