feat(config): skipLegacyWorkersInjection #2872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have added
skipLegacyWorkersInjection: boolean
toDetox.DetoxConfig
, so thatdetox test
command avoids the permanent passthrough of--workers 1
to Jest by default. For the opposite case, when a user specifies a custom workers number via-w, --workers <count>
CLI option, the previous behavior remains the same.{ testRunner: 'nyc jest', runnerConfig: 'e2e/config.js', + skipLegacyWorkersInjection: true,
From now on, the default Jest config file generated by
detox init -r jest
containsmaxWorkers: 1
to prevent an unintended overallocation of devices if there are multiple test files — an average personal computer is likely to have a problem with more than 3-4 simulators/emulators running at once, therefore we add a safeguard mechanism this way.{ + "maxWorkers": 1, "testEnvironment": "./environment", "testRunner": "jest-circus/runner", "testTimeout": 120000, "testRegex": "\\\\.e2e\\\\.js$", "reporters": ["detox/runners/jest/streamlineReporter"], "verbose": true }
The temporary flag,
skipLegacyWorkersInjection
is intended to be removed in the next Detox major release in favor of the new behavior added with this pull request.