Basic support for Jest runner #335
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,39 @@ | ||
| jest.unmock('process'); | ||
|
|
||
| describe('argparse', () => { | ||
| describe('using env variables', () => { | ||
| let argparse; | ||
|
|
||
| beforeEach(() => { | ||
| process.env.fooBar = 'a value'; | ||
| argparse = require('./argparse'); | ||
| }); | ||
|
|
||
| it(`nonexistent key should return undefined result`, () => { | ||
| expect(argparse.getArgValue('blah')).not.toBeDefined(); | ||
| }); | ||
|
|
||
| it(`existing key should return a result`, () => { | ||
| expect(argparse.getArgValue('foo-bar')).toBe('a value'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('using arguments', () => { | ||
| let argparse; | ||
|
|
||
| beforeEach(() => { | ||
| jest.mock('minimist'); | ||
| const minimist = require('minimist'); | ||
| minimist.mockReturnValue({'kebab-case-key': 'a value'}); | ||
| argparse = require('./argparse'); | ||
| }); | ||
|
|
||
| it(`nonexistent key should return undefined result`, () => { | ||
| expect(argparse.getArgValue('blah')).not.toBeDefined(); | ||
| }); | ||
|
|
||
| it(`existing key should return a result`, () => { | ||
| expect(argparse.getArgValue('kebab-case-key')).toBe('a value'); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,10 +16,9 @@ npm install --save-dev jest | |
|
|
||
| You should remove `e2e/mocha.opts`, you no longer need it. | ||
|
|
||
| ### 3. Replace generated detox setup file (e2e/init.js) | ||
|
|
||
| ```js | ||
| const detox = require('detox'); | ||
| const config = require('../package.json').detox; | ||
|
|
||
|
|
@@ -44,15 +43,15 @@ beforeEach(async () => { | |
| Add this part to your `package.json`: | ||
| ```json | ||
| "jest": { | ||
| "setupTestFrameworkScriptFile": "./e2e/init.js" | ||
| }, | ||
| "scripts": { | ||
| "test:e2e": "detox test", | ||
| "test:e2e:build": "detox build" | ||
| } | ||
| ``` | ||
|
|
||
|
There was a problem hiding this comment. Will running without the flag run tests serially? There was a problem hiding this comment. I added the flag here so if you use There was a problem hiding this comment. What is stopping detox from parallelism? There was a problem hiding this comment. a few things, mainly controlling multiple simulators. It's in our roadmap, shouldn't be too hard. |
||
| In the `detox` part of your `package.json`, add `"runner": "jest"` to tell detox that you want to use jest runner instead of mocha. | ||
|
|
||
| ### Writing Tests | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about passing detox command line args? Will those work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can think of a way doing this. Although, in this version I wasn't aiming to provide this. If this is mandatory, we can discuss the approachSorry, misread your comment. What do you mean by "detox cli args"? Can you make an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is, the feature is not 100% usable without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detox test --configuration ios.sim.releasedetox test --loglevel verbosedetox test --debug-synchronizationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which flags are important?
In the previous version there were no recommendations regarding flags so kept it out of scope. However, I'm fine adding important flags to make jest support even better 💪 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotemmiz what is the goal?
or
If we talk about the second one, then it already works like this (commander parses arguments before passing them to test runner)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, but we execute a child process and these argument are not being passed into it.
cp.execSync(command, {stdio: 'inherit'});We probably just need to pass them on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I see. Indeed, we just need to pass arguments to the child process. Then there will be no point in passing all these flags in the command itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like
jestdoesn't support allow custom CLI parameters. The only approach I see is to use environment vars.Using ENV vars will imply changes on the mocha part and the way test cases gets parameters overall.
UPD: I can update
argparselibrary and CLI so instead of additional flags it'll create one-time ENV variables. For user it'll be still the same, all mapping will happen under the hood.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea @Kureev, thank you so much for your efforts here 👍