Upgrade to rn68 #3476
Merged
Upgrade to rn68 #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
force-pushed
the
upgrade-to-rn68
branch
6 times, most recently
from
2d56457 to
094f40b
Compare
Fix error: no visible @interface for 'RCTBundleURLProvider' declares the selector 'jsBundleURLForBundleRoot:fallbackResource:'. The solution is to pass a non-nil value to `fallbackResource`.
asafkorem
force-pushed
the
upgrade-to-rn68
branch
from
4064595 to
4d0ef29
Compare
|
Nice work 💪 |
|
Just wanted to bump #3462 in case it got lost in the shuffle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have integrated all of the necessary adjustment in order to have Detox support and run (test/example projects) using RN 68, in a backwards-compatible way.
TODO: Integrated new RN architecture.