Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for multiple RN version in test project + updated example projects #591

Merged
merged 8 commits into from
Mar 4, 2018
Merged

Better support for multiple RN version in test project + updated example projects #591

merged 8 commits into from
Mar 4, 2018

Conversation

rotemmiz
Copy link
Member

No description provided.

@rotemmiz rotemmiz requested a review from LeoNatan as a code owner February 28, 2018 18:46
@LeoNatan
Copy link
Contributor

Checks failed. Rejected! 😜

@rotemmiz
Copy link
Member Author

Someone is extra joly today 🤪

LeoNatan
LeoNatan reviewed Feb 28, 2018
View reviewed changes
examples/demo-react-native/ios/example.xcodeproj/project.pbxproj Outdated
@@ -317,6 +387,8 @@
children = (
139FDEF41B06529B00C62182 /* libRCTWebSocket.a */,
392FDE331E2E5F680058768A /* libRCTWebSocket-tvOS.a */,
461DC7DB2047304200C366C7 /* libfishhook.a */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added by RN?

examples/demo-react-native/ios/example.xcodeproj/project.pbxproj Outdated
@@ -346,6 +418,14 @@
392FDE451E2E5F680058768A /* libcxxreact.a */,
392FDE471E2E5F680058768A /* libjschelpers.a */,
392FDE491E2E5F680058768A /* libjschelpers.a */,
461DC7EF2047304200C366C7 /* libjsinspector.a */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what that is.

@rotemmiz rotemmiz changed the title updated multi RN version script Better support for multiple RN version in test project + updated example projects Mar 4, 2018
@rotemmiz rotemmiz merged commit 2ff67bf into master Mar 4, 2018
@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 4, 2018

Approved 😂

@LeoNatan LeoNatan deleted the multiVersionTest branch March 12, 2018 20:03
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoNatan LeoNatan LeoNatan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rotemmiz @LeoNatan